fix(devtools): solidjs importing browser utils - #181
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
harry-whorlow
changed the title
71e7aa3 to
15ad3d8
Compare
|
View your CI Pipeline Execution ↗ for commit b2a8f1a
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Pull request overview
This PR refactors pacer-devtools styling to reduce inline style usage in SolidJS components by moving layout concerns into the shared use-styles stylesheet and using CSS custom properties for dynamic sizing.
Changes:
- Replaced inline
height/max-heightand panel width style objects with CSS variables (--shell-slot-height,--left-panel-width). - Moved
StateHeaderinline layout styles intouse-stylesas new class rules. - Removed redundant inline
flex: 1on the right panel in favor of the existing stylesheet rule.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/pacer-devtools/src/styles/use-styles.ts | Adds CSS-variable-driven sizing and new StateHeader helper styles. |
| packages/pacer-devtools/src/components/StateHeader.tsx | Switches from inline style to stylesheet classes for header layout. |
| packages/pacer-devtools/src/components/Shell.tsx | Uses CSS variables instead of inline style objects for slot height and left panel width. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| stateHeaderMeta: css` | ||
| display: flex; | ||
| align-items: center; | ||
| gap: 16px; | ||
| `, |
| stateHeaderReduction: css` | ||
| margin-left: auto; | ||
| font-weight: bold; | ||
| `, |
No description provided.